Test.refactor.coverage #297
Conversation
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
=========================================
+ Coverage 51.81% 52.92% +1.1%
=========================================
Files 25 25
Lines 4624 4631 +7
=========================================
+ Hits 2396 2451 +55
+ Misses 2228 2180 -48
Continue to review full report at Codecov.
|
| @@ -22,7 +22,7 @@ def common_first(self): | |||
|
|
|||
| if self.os == 'linux': | |||
| self.install("ca-certificates") | |||
| self.install("git cmake unzip wget patchelf awscli") | |||
| self.install("git cmake unzip wget patchelf awscli valgrind") | |||
There was a problem hiding this comment.
This will fail on macOS. Better to install Valgrind in:
def linux(self):
self.install("valgrind")
|
This can be way off the current implementation, but as we don't use CMake to run tests, I prefer to drive coverage data collection and report generation outside CMake (the build part is of course ok but it's relatively modest in configuration). TimeSeries has it implemented this way. |
Agree @rafie. will check TS and change accordingly :) |
|
closing in favor of #299 |
to be discussed after #296